langchain4j/model.output coverage tests. #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noticed weirdness in the errors for DateOutputParser and EnumOutputParser; marked with TODOs.
Restriction of DateOutputParser to a strict format.
crutcher
force-pushed
the
crutcher-model.output-tests
branch
from
47ff4f0
to
51812e8
Compare
langchain4j
approved these changes
Feb 8, 2024
There was a problem hiding this comment.
@crutcher good catch, thank you a lot! BTW AiServicesIT.test_extract_date and test_extract_time are failing, I will fix that myself to speedup and include this in the new release (today).
langchain4j
added a commit
that referenced
this pull request
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed weirdness in the errors for DateOutputParser and EnumOutputParser.
Expanded EnumOutputParser to be case-insensitive.
Restricted DateOutputParser to the expected format.