-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store variables as Kubernetes Secrets #2231
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
I think have different stores is ideal but I think it would add complexity. Let's keep it as variable_store for now. Thanks for this PR, ming. Looks really useful. |
f5d04e4
to
8b4517f
Compare
8b4517f
to
f4d84ad
Compare
e1ffb26
to
61d0f3b
Compare
This PR introduces an alternate backend to store variable in kubernetes secrets.
It addresses these two feature requests
#2151
#2150
@ogabrielluiz
This implementation stores both Credential and Generic variables in Kubernetes secrets when setting_service.variable_store = "kubernetes"
Or the second option is to only store the variable type is
Credential
to Kubernetes secrets while the restGeneric
still are stored indb
. For that we can introduce a flagsetting_service.credential_store
Let me know which one is more appropriate.