Skip to content

fix: auth current user on code validation - #6911

Merged
jordanrfrazier merged 11 commits into
mainfrom
add-current-user-auth
Mar 5, 2025
Merged

fix: auth current user on code validation#6911
jordanrfrazier merged 11 commits into
mainfrom
add-current-user-auth

Conversation

@jordanrfrazier

Copy link
Copy Markdown
Collaborator

Auth current user on /code endpoint.

@dosubot dosubot Bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels Mar 4, 2025
@github-actions github-actions Bot added bug Something isn't working and removed bug Something isn't working labels Mar 4, 2025
@github-actions github-actions Bot added bug Something isn't working and removed bug Something isn't working labels Mar 4, 2025
@github-actions github-actions Bot added bug Something isn't working and removed bug Something isn't working labels Mar 4, 2025
@github-actions github-actions Bot added bug Something isn't working and removed bug Something isn't working labels Mar 4, 2025
@codspeed-hq

codspeed-hq Bot commented Mar 4, 2025

Copy link
Copy Markdown

CodSpeed Performance Report

Merging #6911 will degrade performances by 35.9%

Comparing add-current-user-auth (40eab67) with main (e5f654a)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 17 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
test_build_flow_invalid_job_id 8 ms 12.5 ms -35.9%
test_cancel_nonexistent_build 13.8 ms 10.5 ms +31.15%

@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Mar 4, 2025
@github-actions github-actions Bot added bug Something isn't working and removed bug Something isn't working labels Mar 4, 2025
@github-actions github-actions Bot added bug Something isn't working and removed bug Something isn't working labels Mar 4, 2025
@jordanrfrazier
jordanrfrazier enabled auto-merge March 4, 2025 16:46
@github-actions github-actions Bot added bug Something isn't working and removed bug Something isn't working labels Mar 5, 2025
@dosubot dosubot Bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Mar 5, 2025
@github-actions github-actions Bot added bug Something isn't working and removed bug Something isn't working labels Mar 5, 2025
@github-actions github-actions Bot added bug Something isn't working and removed bug Something isn't working labels Mar 5, 2025
@github-actions github-actions Bot added bug Something isn't working and removed bug Something isn't working labels Mar 5, 2025
@jordanrfrazier
jordanrfrazier added this pull request to the merge queue Mar 5, 2025
Merged via the queue into main with commit faac4db Mar 5, 2025
@jordanrfrazier
jordanrfrazier deleted the add-current-user-auth branch March 5, 2025 17:24
Yukiyukiyeah pushed a commit that referenced this pull request Mar 31, 2025
* Add user auth for /code endpoint

* import

* revert

* [autofix.ci] apply automated fixes

* [autofix.ci] apply automated fixes (attempt 2/3)

* ruff

* fix tests

* [autofix.ci] apply automated fixes

* ruff

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Nadir J <31660040+NadirJ@users.noreply.github.com>
@ottusp

ottusp commented Aug 11, 2025

Copy link
Copy Markdown

This PR solves #696

0xAverageUser pushed a commit to get-xor/coreweave-demo-2026-05 that referenced this pull request May 20, 2026
…urce

Binds CurrentActiveUser dependency to POST /api/v1/validate/code,
rejecting unauthenticated requests before the FastAPI route parses
the body and invokes validate_code(). Closes the unauthenticated
RCE chain described in CVE-2025-3248.

Upstream PR: langflow-ai/langflow#6911
Released in: Langflow 1.3.0 (2025-03-31)
0xAverageUser pushed a commit to get-xor/coreweave-demo-2026-05 that referenced this pull request May 20, 2026
…urce

Binds CurrentActiveUser dependency to POST /api/v1/validate/code,
rejecting unauthenticated requests before the FastAPI route parses
the body and invokes validate_code(). Closes the unauthenticated
RCE chain described in CVE-2025-3248.

Upstream PR: langflow-ai/langflow#6911
Released in: Langflow 1.3.0 (2025-03-31)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants