fix(openai): GPT-5 series models contain incorrect parameters - #1444
Merged
Conversation
- Add claude-opus-4-1-20250805.yaml with advanced features - Support for thinking mode with configurable budget - Enhanced prompt caching capabilities - Vision, tool calling, and document processing support - Bump version to 0.1.2 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
This reverts commit 63c98db.
fdb02983rhy
marked this pull request as ready for review
August 7, 2025 18:50
- Add gpt-5, gpt-5-mini, gpt-5-nano model variants - Include dated versions (2025-08-07) and latest versions - Configure model parameters and capabilities for new GPT-5 series
- Add gpt-5, gpt-5-mini, gpt-5-nano model variants to _position.yaml - Include dated versions (2025-08-07) and latest versions - Position models logically between GPT-4.1 and GPT-4o series
fdb02983rhy
marked this pull request as draft
August 7, 2025 19:13
Member
|
Great! I think you can copy the parameters from o3. |
Member
|
And...just a suggestion - would you be open to rearranging the order of the models in the position so they go from newest to oldest? |
nezhar
reviewed
Aug 7, 2025
…uency_penalty (except gpt-5-chat-latest); runtime: treat o* and gpt-5* as thinking-series, map max_tokens to max_completion_tokens
Eliminated the 'json_object' option from the 'response_format' parameter in all GPT-5, GPT-5-mini, and GPT-5-nano YAML configuration files to align with updated model capabilities or requirements.
Contributor
Author
|
Ok fully tested |
Contributor
Author
Sure thing, done. |
nezhar
approved these changes
Aug 7, 2025
Moved GPT-4 and related model entries to a new position in the list for improved organization and consistency.
fdb02983rhy
marked this pull request as ready for review
August 7, 2025 19:54
laipz8200
approved these changes
Aug 7, 2025
Member
|
Awesome work! Thank you for your contribution! |
5 tasks
Frederick2313072
pushed a commit
that referenced
this pull request
Aug 28, 2025
* Add Claude Opus 4.1 model support - Add claude-opus-4-1-20250805.yaml with advanced features - Support for thinking mode with configurable budget - Enhanced prompt caching capabilities - Vision, tool calling, and document processing support - Bump version to 0.1.2 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * Revert "Add Claude Opus 4.1 model support" This reverts commit 63c98db. * chore: add gpt-5 series * chore: update manifest and requirements for GPT-5 series * Add GPT-5 series model configurations - Add gpt-5, gpt-5-mini, gpt-5-nano model variants - Include dated versions (2025-08-07) and latest versions - Configure model parameters and capabilities for new GPT-5 series * Add GPT-5 series models to position configuration - Add gpt-5, gpt-5-mini, gpt-5-nano model variants to _position.yaml - Include dated versions (2025-08-07) and latest versions - Position models logically between GPT-4.1 and GPT-4o series * OpenAI: GPT-5 series YAML cleanup: remove top_p/presence_penalty/frequency_penalty (except gpt-5-chat-latest); runtime: treat o* and gpt-5* as thinking-series, map max_tokens to max_completion_tokens * OpenAI: update LLM _position.yaml for GPT-5 series positioning * Update _position.yaml * Remove json_object option from GPT-5 model configs Eliminated the 'json_object' option from the 'response_format' parameter in all GPT-5, GPT-5-mini, and GPT-5-nano YAML configuration files to align with updated model capabilities or requirements. * Reorder GPT-4 model entries in _position.yaml Moved GPT-4 and related model entries to a new position in the list for improved organization and consistency. --------- Co-authored-by: Claude <noreply@anthropic.com>
This was referenced Sep 5, 2025
Closed
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues or Context
Area.mp4
This PR contains Changes to Non-Plugin
This PR contains Changes to Non-LLM Models Plugin
This PR contains Changes to LLM Models Plugin
Version Control (Any Changes to the Plugin Will Require Bumping the Version)
VersionField, Not in Meta Section)Dify Plugin SDK Version
dify_plugin>=0.3.0,<0.5.0is in requirements.txt (SDK docs)Environment Verification (If Any Code Changes)
Local Deployment Environment
SaaS Environment