Skip to content

fix(openai): GPT-5 series models contain incorrect parameters - #1444

Merged
laipz8200 merged 14 commits into
langgenius:mainfrom
fdb02983rhy:chore/add-gpt-5-series
Aug 7, 2025
Merged

fix(openai): GPT-5 series models contain incorrect parameters#1444
laipz8200 merged 14 commits into
langgenius:mainfrom
fdb02983rhy:chore/add-gpt-5-series

Conversation

@fdb02983rhy

@fdb02983rhy fdb02983rhy commented Aug 7, 2025

Copy link
Copy Markdown
Contributor

Related Issues or Context

Area.mp4

This PR contains Changes to Non-Plugin

  • Documentation
  • Other

This PR contains Changes to Non-LLM Models Plugin

  • I have Run Comprehensive Tests Relevant to My Changes

This PR contains Changes to LLM Models Plugin

  • My Changes Affect Message Flow Handling (System Messages and User→Assistant Turn-Taking)
  • My Changes Affect Tool Interaction Flow (Multi-Round Usage and Output Handling, for both Agent App and Agent Node)
  • My Changes Affect Multimodal Input Handling (Images, PDFs, Audio, Video, etc.)
  • My Changes Affect Multimodal Output Generation (Images, Audio, Video, etc.)
  • My Changes Affect Structured Output Format (JSON, XML, etc.)
  • My Changes Affect Token Consumption Metrics
  • My Changes Affect Other LLM Functionalities (Reasoning Process, Grounding, Prompt Caching, etc.)
  • Other Changes (Add New Models, Fix Model Parameters etc.)

Version Control (Any Changes to the Plugin Will Require Bumping the Version)

  • I have Bumped Up the Version in Manifest.yaml (Top-Level Version Field, Not in Meta Section)

Dify Plugin SDK Version

  • I have Ensured dify_plugin>=0.3.0,<0.5.0 is in requirements.txt (SDK docs)

Environment Verification (If Any Code Changes)

Local Deployment Environment

  • Dify Version is: , I have Tested My Changes on Local Deployment Dify with a Clean Environment That Matches the Production Configuration.

SaaS Environment

  • I have Tested My Changes on cloud.dify.ai with a Clean Environment That Matches the Production Configuration

fdb02983rhy and others added 5 commits August 6, 2025 22:26
- Add claude-opus-4-1-20250805.yaml with advanced features
- Support for thinking mode with configurable budget
- Enhanced prompt caching capabilities
- Vision, tool calling, and document processing support
- Bump version to 0.1.2

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@fdb02983rhy
fdb02983rhy marked this pull request as ready for review August 7, 2025 18:50
- Add gpt-5, gpt-5-mini, gpt-5-nano model variants
- Include dated versions (2025-08-07) and latest versions
- Configure model parameters and capabilities for new GPT-5 series
- Add gpt-5, gpt-5-mini, gpt-5-nano model variants to _position.yaml
- Include dated versions (2025-08-07) and latest versions
- Position models logically between GPT-4.1 and GPT-4o series
@fdb02983rhy fdb02983rhy changed the title Chore/add gpt 5 series Fix/correct gpt 5 series parameters Aug 7, 2025
@fdb02983rhy
fdb02983rhy marked this pull request as draft August 7, 2025 19:13
@laipz8200

Copy link
Copy Markdown
Member

Great! I think you can copy the parameters from o3.

@laipz8200

Copy link
Copy Markdown
Member

And...just a suggestion - would you be open to rearranging the order of the models in the position so they go from newest to oldest?

@laipz8200 laipz8200 changed the title Fix/correct gpt 5 series parameters fix(openai): GPT-5 series models contain incorrect parameters Aug 7, 2025
Comment thread models/openai/models/llm/_position.yaml Outdated
…uency_penalty (except gpt-5-chat-latest); runtime: treat o* and gpt-5* as thinking-series, map max_tokens to max_completion_tokens
Eliminated the 'json_object' option from the 'response_format' parameter in all GPT-5, GPT-5-mini, and GPT-5-nano YAML configuration files to align with updated model capabilities or requirements.
@fdb02983rhy

Copy link
Copy Markdown
Contributor Author

Ok fully tested

@fdb02983rhy

Copy link
Copy Markdown
Contributor Author

And...just a suggestion - would you be open to rearranging the order of the models in the position so they go from newest to oldest?

Sure thing, done.

Moved GPT-4 and related model entries to a new position in the list for improved organization and consistency.
@fdb02983rhy
fdb02983rhy marked this pull request as ready for review August 7, 2025 19:54
@laipz8200
laipz8200 merged commit 67f5855 into langgenius:main Aug 7, 2025
2 checks passed
@laipz8200

Copy link
Copy Markdown
Member

Awesome work! Thank you for your contribution!

Frederick2313072 pushed a commit that referenced this pull request Aug 28, 2025
* Add Claude Opus 4.1 model support

- Add claude-opus-4-1-20250805.yaml with advanced features
- Support for thinking mode with configurable budget
- Enhanced prompt caching capabilities
- Vision, tool calling, and document processing support
- Bump version to 0.1.2

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

* Revert "Add Claude Opus 4.1 model support"

This reverts commit 63c98db.

* chore: add gpt-5 series

* chore: update manifest and requirements for GPT-5 series

* Add GPT-5 series model configurations

- Add gpt-5, gpt-5-mini, gpt-5-nano model variants
- Include dated versions (2025-08-07) and latest versions
- Configure model parameters and capabilities for new GPT-5 series

* Add GPT-5 series models to position configuration

- Add gpt-5, gpt-5-mini, gpt-5-nano model variants to _position.yaml
- Include dated versions (2025-08-07) and latest versions
- Position models logically between GPT-4.1 and GPT-4o series

* OpenAI: GPT-5 series YAML cleanup: remove top_p/presence_penalty/frequency_penalty (except gpt-5-chat-latest); runtime: treat o* and gpt-5* as thinking-series, map max_tokens to max_completion_tokens

* OpenAI: update LLM _position.yaml for GPT-5 series positioning

* Update _position.yaml

* Remove json_object option from GPT-5 model configs

Eliminated the 'json_object' option from the 'response_format' parameter in all GPT-5, GPT-5-mini, and GPT-5-nano YAML configuration files to align with updated model capabilities or requirements.

* Reorder GPT-4 model entries in _position.yaml

Moved GPT-4 and related model entries to a new position in the list for improved organization and consistency.

---------

Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants