Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IndexOutOfBoundsException with LibreOffice add-on #2602

Closed
danielnaber opened this issue Mar 23, 2020 · 13 comments
Closed

IndexOutOfBoundsException with LibreOffice add-on #2602

danielnaber opened this issue Mar 23, 2020 · 13 comments

Comments

@danielnaber
Copy link
Member

@danielnaber danielnaber commented Mar 23, 2020

With this test document, I get an error: https://github.com/languagetool-org/languagetool/blob/master/languagetool-office-extension/src/test/resources/manual-testing.odt?raw=true

Bildschirmfoto von 2020-03-23 13-44-17

My settings:
Bildschirmfoto von 2020-03-23 13-47-56

Using LibreOffice 6.3.4.2 under Ubuntu 18.04. I tried several times and it seems to be reproducible 100%. No editing is needed, the error occurs a few seconds after the document is opened.

@FredKruse Is this easily fixable? As there are other issues, do you think we should postpone the release of LT 4.9?

@marcoagpinto

This comment has been minimized.

Copy link
Member

@marcoagpinto marcoagpinto commented Mar 23, 2020

@danielnaber

If LT 4.9 is postponed, may I update the spelling.txt and added.txt for Portuguese and also try to release the GB speller update tomorrow and it be included in 4.9?

@danielnaber

This comment has been minimized.

Copy link
Member Author

@danielnaber danielnaber commented Mar 23, 2020

If LT 4.9 is postponed, may I update the spelling.txt and added.txt for Portuguese and also try to release the GB speller update tomorrow and it be included in 4.9?

If the release is postponed, it means the feature freeze will be longer. So adding a few entries to spelling.txt is okay, but I don't think we should have dict updates before the release.

@marcoagpinto

This comment has been minimized.

Copy link
Member

@marcoagpinto marcoagpinto commented Mar 23, 2020

@danielnaber

Thanks.

I have just committed some improvements.

The GB speller will be after 4.9 is released.

FredKruse added a commit that referenced this issue Mar 23, 2020
@FredKruse

This comment has been minimized.

Copy link
Contributor

@FredKruse FredKruse commented Mar 24, 2020

@danielnaber, @marcoagpinto: Yesterday evening, I committed a bug fix which hopefully solves both bugs. Please test it with your examples.

@marcoagpinto

This comment has been minimized.

Copy link
Member

@marcoagpinto marcoagpinto commented Mar 24, 2020

@FredKruse
The fixes will only be available tonight, I believe, since LanguageTool releases snapshots at around 7pm.

I will only be able to test tomorrow due to that.

@danielnaber

This comment has been minimized.

Copy link
Member Author

@danielnaber danielnaber commented Mar 24, 2020

@marcoagpinto I've uploaded a build here, could you test that? My issue (IndexOutOfBounds) is fixed with that: https://we.tl/t-kKghCvzdRj

@marcoagpinto

This comment has been minimized.

Copy link
Member

@marcoagpinto marcoagpinto commented Mar 24, 2020

@danielnaber

I have just tested it and:
languagetool_crash_20200324

@danielnaber

This comment has been minimized.

Copy link
Member Author

@danielnaber danielnaber commented Mar 24, 2020

@marcoagpinto Does that only happen with your thesis or can you provide another document to reproduce? @FredKruse I'll continue with the 4.9 release, but it will not contain the LibreOffice add-on yet. We can then fix it and publish it separately in a few days.

@marcoagpinto

This comment has been minimized.

Copy link
Member

@marcoagpinto marcoagpinto commented Mar 24, 2020

@danielnaber
I haven't been writing much with LibreOffice, so, I am not sure.

I have been using LibreOffice more to create and test LT rules.

@marcoagpinto

This comment has been minimized.

Copy link
Member

@marcoagpinto marcoagpinto commented Mar 24, 2020

I have opened a small .odt with LT 4.9 disabled and then with it enabled, and waited 10 minutes for each.

There is a huge RAM usage difference with LT on.

Disabled:
task_manager_lt_disabled_20200324

Enabled:
task_manager_lt_enabled_20200324

See attached file:
rule_test_verb_agreements_20200218.zip

@danielnaber

This comment has been minimized.

Copy link
Member Author

@danielnaber danielnaber commented Mar 24, 2020

There is a huge RAM usage difference with LT on.

Java takes as much RAM as it can get (put simply). Unless there's a real issue for users, this is nothing to worry about.

@marcoagpinto

This comment has been minimized.

Copy link
Member

@marcoagpinto marcoagpinto commented Mar 24, 2020

Hello!

@danielnaber @FredKruse

Again:
lt_crash_20200324

Here is a reproducible example, a 400-page sample which is the number of pages of my thesis.

Just open the ODT, wait a couple of minutes, click on the first page, and start scrolling down with the mouse wheel.

It will open a crash window several times.
Roman_page_numbers_all_over_sections_20200324.zip

@danielnaber

This comment has been minimized.

Copy link
Member Author

@danielnaber danielnaber commented Mar 27, 2020

Closing, as this issue (IndexOutOfBoundsException) is fixed. Everything else should be discussed in separate issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.