Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export and Function Name Conventions #454

Closed
ccoffrin opened this issue Jan 17, 2019 · 1 comment · Fixed by #542
Closed

Export and Function Name Conventions #454

ccoffrin opened this issue Jan 17, 2019 · 1 comment · Fixed by #542
Milestone
v0.12.0

Comments

@ccoffrin
Copy link
Member

Update to _ naming convention for internal functions.

Follow JuMP guidelines for function exports. jump-dev/JuMP.jl#1761
@ccoffrin ccoffrin added this to the v1.0.0 milestone Jan 17, 2019
@ccoffrin
Copy link
Member Author

Also make sure to add ! to mutating functions.

ccoffrin added a commit that referenced this issue May 17, 2019
@ccoffrin
add ! to mutating data functions, progress on #454
59e8fb8
This was referenced Jun 4, 2019
Merged
Closed
@ccoffrin ccoffrin mentioned this issue Jun 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.12.0
Development

Successfully merging a pull request may close this issue.

Features for PowerModels v0.12 lanl-ansi/PowerModels.jl
1 participant
@ccoffrin