New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch LANSuite version string from configuration to constant LANSUITE_VERSION #335

Merged
merged 2 commits into from Jun 11, 2018

Conversation

Projects
None yet
2 participants
@andygrunwald
Collaborator

andygrunwald commented Jun 11, 2018

The LANSuite Version is right now part of the configuration.
This configuration is created by the (end)user.

The string version defined which state of LANSuite you are using.
In the code itself, it is only used to show the version. But it doesn't have a bigger effect and should not be edited by the user.

The development team + contributor of LANSuite are defining by development the version of LANSuite. Furthermore, the version as constant can be used for a better upgrade procedure.

@M4LuZ

M4LuZ approved these changes Jun 11, 2018

@M4LuZ M4LuZ merged commit 51a422c into master Jun 11, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@M4LuZ M4LuZ deleted the switch-lansuite-version-to-constant branch Jun 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment