New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

184 discord module #355

Merged
merged 11 commits into from Sep 13, 2018

Conversation

Projects
None yet
2 participants
@M4LuZ
Collaborator

M4LuZ commented Sep 9, 2018

Initial import of module "Discord"
What it does:

  • Make a box available that shows users and channels of a discord server id
    What should happen somewhen:
  • Merge this with the TS3 code to make a general "Voiceserver" module that supports both

fixes #184

@M4LuZ M4LuZ requested a review from andygrunwald Sep 9, 2018

andygrunwald and others added some commits Sep 11, 2018

@M4LuZ M4LuZ added this to the LanSuite 5.0 RC milestone Sep 12, 2018

@M4LuZ

This comment has been minimized.

Show comment
Hide comment
@M4LuZ

M4LuZ Sep 12, 2018

Collaborator

I would suggest just to pass this through as this fresh code unrelated to anything else.
If we find an issue, we can work it out later (latest with the integration into that aforementioned VoiceServer class). But I would like to have this in as feature for the next release

Collaborator

M4LuZ commented Sep 12, 2018

I would suggest just to pass this through as this fresh code unrelated to anything else.
If we find an issue, we can work it out later (latest with the integration into that aforementioned VoiceServer class). But I would like to have this in as feature for the next release

Show resolved Hide resolved modules/discord/boxes/discord.php

@M4LuZ M4LuZ merged commit a785ab0 into master Sep 13, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@M4LuZ M4LuZ deleted the 184-discord-module branch Sep 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment