Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Your theme's demo is not working on the Hugo Themes website #88

Closed
onedrawingperday opened this issue Nov 8, 2018 · 4 comments

Comments

@onedrawingperday
Copy link

@onedrawingperday onedrawingperday commented Nov 8, 2018

Hello @laozhu

I see that since commit 26d0efa your theme is using Hugo Pipes.

However you have not committed the generated resources of your theme and as a result your theme's demo fails to generate on the Hugo website.

To fix this issue please have a look at the updated README of Hugo Themes: https://github.com/gohugoio/hugoThemes#resources You need to commit the /resources/ directory and its contents in your theme's repository.

If you have any questions do not hesitate to ask me or @digitalcraftsman

@laozhu

This comment has been minimized.

Copy link
Owner

@laozhu laozhu commented Nov 8, 2018

@onedrawingperday Demo fixed.

@onedrawingperday

This comment has been minimized.

Copy link
Author

@onedrawingperday onedrawingperday commented Nov 8, 2018

@laozhu Thank you. I confirm that the demo is now generated with the Themes Site Build Script.

However the theme's Hugo Pipes Assets are not loading.

To fix this issue please see the Common Permalink Issues in the Hugo Themes README.

If you are using Hugo Pipes to publish your theme's resources you need to use .RelPermalink in the templates, so that these assets are served correctly on the website.

For example change line 104 of layouts/partials/ to:
<link rel="stylesheet" href="{{ $style.RelPermalink }}">

@laozhu

This comment has been minimized.

Copy link
Owner

@laozhu laozhu commented Nov 9, 2018

@onedrawingperday Demo fixed again with commit d239620

@onedrawingperday

This comment has been minimized.

Copy link
Author

@onedrawingperday onedrawingperday commented Nov 9, 2018

@laozhu

I confirm that now your theme's demo is generated when I execute the Build Script.

This will be reflected on the Hugo website the next time themes are updated.

Thanks.

laozhu added a commit that referenced this issue Dec 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.