Skip to content

fix: fixed dark mode under review progress bar and h2 color discrepancy #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 15, 2025
Merged

fix: fixed dark mode under review progress bar and h2 color discrepancy #208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/components/src/heading.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ export const H2 = styled.h2.withConfig({
font-size: ${FontSizes.h2};
letter-spacing: 0.9px;
${(props) => props.noMargin && 'margin: 0;'};
color: ${(props) => props.theme.darkFont};
`

export const Title = styled(BaseHeader).withConfig({
Expand Down
1 change: 1 addition & 0 deletions packages/components/src/theme/dark-theme.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ export const darkTheme: DefaultTheme = {
progressBar: '#F5F5F5',
overlay: '#41465B',
faq: '#C6CDE7',
reviewGrey: '#737373',

//Fonts
darkFont: '#FFFFFF',
Expand Down
1 change: 1 addition & 0 deletions packages/components/src/theme/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ declare module 'styled-components' {
progressBar: string
overlay: string
faq: string
reviewGrey: string

// Fonts
darkFont: string
Expand Down
1 change: 1 addition & 0 deletions packages/components/src/theme/light-theme.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ export const lightTheme: DefaultTheme = {
progressBar: '#F5F5F5',
overlay: '#333333',
faq: '#AAB8EC',
reviewGrey: '#4F4F4F',

//Fonts
darkFont: '#333333',
Expand Down
2 changes: 1 addition & 1 deletion packages/frontend/src/helper/report-helper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ type UseReportHelper = {
const TraineeReportStatusColors: Record<ReportStatus, keyof DefaultTheme> = {
archived: 'successGreen',
reopened: 'errorRed',
review: 'mediumFont',
review: 'reviewGrey',
todo: 'iconBlue',
}

Expand Down