fix WizardStep class property title does not return the value of it's title method

[bfiessinger]

Currently a WizardSteps title property does not respect the return value of $this->title(). For Steps with dynamic titles this should be fixed.

[ksassnowski]

I feel like there’s a bit of confusing about the connection between the $title property and the title() function of the WizardStep class.

Internally, Arcanist only ever refers to the title() method of the step (https://github.com/laravel-arcanist/arcanist/blob/main/src/AbstractWizard.php#L270). It’s just that the default implementation of the method simply returns the $title property. What this means is that you’re only supposed to use title() method when accessing a step’s title. But I can see how that’s not obvious since the field is also public.

That being said, I don’t really see an issue with merging this PR since it would remove the ambiguity and doesn’t really break any behavior.

[ksassnowski]

Can you add a test or two for the WizardStep to check that the $title property gets set correctly when calling $step->init(...)?

[bfiessinger]

Sorry did not have had time to update this PR. But in the meantime I encountered some issues when merging this, e.g. the title method won't be able to make use of $this->data('key') so I'm closing this. For now it's only possible to get the computed title by the steps array.