Fix issue with nested configuration keys #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ConfigurationFactory used the Collection class for retrieving configuration keys, but the Collection class does not support nested key names. This caused the retrieval of the schema.filter key to always return the default value, which would never filter any tables. - Switched to using the Repository class because it properly supports nested keys. - Fixed the mock value for the schema configuration in the ConfigurationFactoryTests. It's a nested array, not a flattened array. - Fixed setFilterSchemaAssetsExpression() expectations in unit tests as Mockery::with() detects regular expressions and uses them when performing argument matching. This was causing false negatives when asserting method call arguments matched expected values. Added Mockery::mustBe() to use strict equality checks.
Contributor
|
Thanks! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ConfigurationFactoryused theCollectionclass for retrievingconfiguration keys, but the
Collectionclass does not support nestedkey names. This caused the retrieval of the
schema.filterkey to alwaysreturn the default value, which would never filter any tables.
Switched to using the
Repositoryclass because it properlysupports nested keys.
Fixed the mock value for the schema configuration in the
ConfigurationFactoryTests. It's a nested array, not a flattenedarray.
Fixed
setFilterSchemaAssetsExpression()expectations in unit testsas
Mockery::with()detects regular expressions and uses them whenperforming argument matching. This was causing false negatives
when asserting method call arguments matched expected values.
Added
Mockery::mustBe()to use strict equality checks.