-
Notifications
You must be signed in to change notification settings - Fork 179
LogFormatter convertParams fix for passing nested array as params #102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Can you back this up with unit tests, please :) |
|
I'll add the tests. |
|
Can you post file logger example, I didn't notice anything strange when I tested it |
|
is it what you want? :) |
|
hm perhaps the arrays should be escaped then. |
|
These sqls are just for logging, unescaped strings looks much better, shall we just leave it alone? |
|
Better safe than sorry } else {
$param = e($param);
}
return (string) $param; |
|
Can you make the change I suggested? |
LogFormatter convertParams fix for passing nested array as params
|
👍 |
|
@patrickbrouwers Can we tag a new release with this pr? |
|
Sorry, completely forgot about this. Yes, will do. |
add support to doctrine json_array type