Skip to content

Conversation

@0x9be00ff1
Copy link

add support to doctrine json_array type

@patrickbrouwers
Copy link
Contributor

Can you back this up with unit tests, please :)

@0x9be00ff1
Copy link
Author

I'll add the tests.
Is it proper to covert params using laravel e helper? it looks little unfriendly when using a FileLogger.

@patrickbrouwers
Copy link
Contributor

Can you post file logger example, I didn't notice anything strange when I tested it

@0x9be00ff1
Copy link
Author

SELECT * FROM table WHERE column = "{"key1":"value1","key2":{"key21":"value22"}}

is it what you want? :)

@patrickbrouwers
Copy link
Contributor

hm perhaps the arrays should be escaped then.

@0x9be00ff1
Copy link
Author

These sqls are just for logging, unescaped strings looks much better, shall we just leave it alone?
or we need something like PDO::quote().

@patrickbrouwers
Copy link
Contributor

Better safe than sorry

} else {
    $param = e($param);
}

return (string) $param;

@patrickbrouwers
Copy link
Contributor

Can you make the change I suggested?

patrickbrouwers added a commit that referenced this pull request Nov 17, 2015
LogFormatter convertParams fix for passing nested array as params
@patrickbrouwers patrickbrouwers merged commit 5e8ec51 into laravel-doctrine:1.0 Nov 17, 2015
@patrickbrouwers
Copy link
Contributor

👍

@0x9be00ff1
Copy link
Author

@patrickbrouwers Can we tag a new release with this pr?

@patrickbrouwers
Copy link
Contributor

Sorry, completely forgot about this. Yes, will do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants