Skip to content

[FEATURE] Show Entity class name when no factory exists #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 11, 2017
Merged

[FEATURE] Show Entity class name when no factory exists #235

merged 1 commit into from
May 11, 2017

Conversation

@Korri
Copy link
Contributor

@Korri Korri commented May 11, 2017

Mimics Laravel's original way of doing it and helps find what needs to be implemented.

Changes proposed in this pull request:

  • Will print class name after factory name when no factory is found.

This:

Unable to locate factory with name [default].

Becomes this:

Unable to locate factory with name [default] [App\User].

@Korri
Include class name inside factory not found error
407f201 
Mimics Laravel's original way of doing it and helps find what needs to be implemented.
@Korri Korri changed the title Include class name inside factory not found error [Feature] Include class name inside factory not found error May 11, 2017
@Korri Korri changed the title [Feature] Include class name inside factory not found error [FEATURE] Include class name inside factory not found error May 11, 2017
@patrickbrouwers patrickbrouwers merged commit 9b9dad3 into laravel-doctrine:1.3 May 11, 2017
@patrickbrouwers
Copy link
Contributor

patrickbrouwers commented May 11, 2017

Thanks for your contribution!

@Korri Korri changed the title [FEATURE] Include class name inside factory not found error [FEATURE] Show Entity class name when no factory exists May 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Korri @patrickbrouwers