Clean up config migrator command and tests #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
FoxxMD
commented
Sep 15, 2015
FoxxMD
commented
- A few bug fixes in blade template
- Cleaned up command to remove switch and extra functions
- Refactor tests to assert file is generated and sanity check for minimal configuration (manager exists)
* Run assertions for file existence and sanity check for a manager * Refactor into abstract class for reusability * Polyfill missing laravel helper functions
patrickbrouwers
added a commit
that referenced
this pull request
Sep 15, 2015
Clean up config migrator command and tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.