Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update composer.json #26

Merged
merged 1 commit into from Feb 18, 2018
Merged

Update composer.json #26

merged 1 commit into from Feb 18, 2018

Conversation

wanghanlin
Copy link
Contributor

@wanghanlin wanghanlin commented Feb 17, 2018

support Laravel 5.5 and 5.6

close #23
close #19

support Laravel 5.5 and 5.6
@themsaid themsaid merged commit af6a44b into laravel-notification-channels:master Feb 18, 2018
@jcrawford
Copy link

jcrawford commented Mar 2, 2018

It would appear this does not quite fix things for 5.5 or 5.6. The reason is that the pusher-php-server at version 2.6.4 will not work with 5.5. prior to version 3.0 the Pusher class was in the global namespace. As of Laravel 5.5 they started looking for Puaher\Pusher which is only available with pusher-php-server 3.0

I can install 3.0 manually but this library requires 2.6.4 so i cannot seem to get around a composer install

Your requirements could not be resolved to an installable set of packages.

Problem 1
- laravel-notification-channels/pusher-push-notifications 1.0.4 requires pusher/pusher-php-server 2.6.* -> satisfiable by pusher/pusher-php-server[2.6.1, 2.6.2, 2.6.3, 2.6.4, v2.6.0] but these conflict with your requirements or minimum-stability.

using 2.6.4 I get the following errors.

In BroadcastManager.php line 213:
Class 'Pusher\Pusher' not found

@wanghanlin
Copy link
Contributor Author

@jcrawford Yes, I realised that already and submitted #27 and used new pusher API, but it's not been merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please add support for Laravel 5.5 Laravel upgrade to 5.4
3 participants