From f3edf592d062f784ad05f21036c7cb8080f16c7c Mon Sep 17 00:00:00 2001 From: Nathanael Esayeas Date: Thu, 4 Mar 2021 14:14:45 -0500 Subject: [PATCH 1/3] Add string limit for faker word --- src/Generators/FactoryGenerator.php | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/Generators/FactoryGenerator.php b/src/Generators/FactoryGenerator.php index 69655711..2c3f760c 100644 --- a/src/Generators/FactoryGenerator.php +++ b/src/Generators/FactoryGenerator.php @@ -245,6 +245,10 @@ protected function buildDefinition(Model $model) $faker = 'word'; } + if(($faker === 'word') && (!empty($column->attributes()))){ + $faker = sprintf("regexify('[A-Za-z0-9]{%s}')", current($column->attributes())); + } + if (Blueprint::isLaravel8OrHigher()) { $definition .= '$this->faker->' . $faker; } else { From 7b0e32871a4d5c7fb3773c3b792578bec6b40271 Mon Sep 17 00:00:00 2001 From: Nathanael Esayeas Date: Thu, 4 Mar 2021 14:22:54 -0500 Subject: [PATCH 2/3] Update tests and fixtures --- tests/fixtures/drafts/phone.yaml | 3 ++- tests/fixtures/factories/phone-laravel8.php | 1 + tests/fixtures/factories/phone.php | 1 + 3 files changed, 4 insertions(+), 1 deletion(-) diff --git a/tests/fixtures/drafts/phone.yaml b/tests/fixtures/drafts/phone.yaml index 3970b0b7..4d065cdd 100644 --- a/tests/fixtures/drafts/phone.yaml +++ b/tests/fixtures/drafts/phone.yaml @@ -6,4 +6,5 @@ models: type: enum:home,cell status: set:archived,deleted foo: morphs - bar: morphs nullable \ No newline at end of file + bar: morphs nullable + tag: string:3 \ No newline at end of file diff --git a/tests/fixtures/factories/phone-laravel8.php b/tests/fixtures/factories/phone-laravel8.php index f93698d3..f60ef433 100644 --- a/tests/fixtures/factories/phone-laravel8.php +++ b/tests/fixtures/factories/phone-laravel8.php @@ -31,6 +31,7 @@ public function definition() 'status' => $this->faker->randomElement(["archived","deleted"]), 'foo_id' => $this->faker->randomDigitNotNull, 'foo_type' => $this->faker->word, + 'tag' => $this->faker->regexify('[A-Za-z0-9]{3}'), ]; } } diff --git a/tests/fixtures/factories/phone.php b/tests/fixtures/factories/phone.php index 2fabb31e..1a9102b3 100644 --- a/tests/fixtures/factories/phone.php +++ b/tests/fixtures/factories/phone.php @@ -14,5 +14,6 @@ 'status' => $faker->randomElement(["archived","deleted"]), 'foo_id' => $faker->randomDigitNotNull, 'foo_type' => $faker->word, + 'tag' => $faker->regexify('[A-Za-z0-9]{3}'), ]; }); From 0c883d556e2c349beba5396dd54f55f6edcac885 Mon Sep 17 00:00:00 2001 From: Nathanael Esayeas Date: Thu, 4 Mar 2021 14:38:33 -0500 Subject: [PATCH 3/3] Appease the CI gods --- src/Generators/FactoryGenerator.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Generators/FactoryGenerator.php b/src/Generators/FactoryGenerator.php index 2c3f760c..eadbd75b 100644 --- a/src/Generators/FactoryGenerator.php +++ b/src/Generators/FactoryGenerator.php @@ -245,7 +245,7 @@ protected function buildDefinition(Model $model) $faker = 'word'; } - if(($faker === 'word') && (!empty($column->attributes()))){ + if (($faker === 'word') && (!empty($column->attributes()))) { $faker = sprintf("regexify('[A-Za-z0-9]{%s}')", current($column->attributes())); }