Add default value for useRef calls in .tsx files#348
Merged
taylorotwell merged 1 commit intolaravel:1.xfrom Jan 15, 2024
matthiasweiss:add_default_value_useref
Merged
Add default value for useRef calls in .tsx files#348taylorotwell merged 1 commit intolaravel:1.xfrom matthiasweiss:add_default_value_useref
taylorotwell merged 1 commit intolaravel:1.xfrom
matthiasweiss:add_default_value_useref
Conversation
jessarcher
approved these changes
Jan 15, 2024
Member
jessarcher
left a comment
There was a problem hiding this comment.
Looks good to me. The React docs demonstrate passing an initial value of null in this scenario too.
https://react.dev/reference/react/useRef#manipulating-the-dom-with-a-ref
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes missing default values for
useRefcalls that use generics, in this caseHTMLInputElement.Currently the returned value is inferred as
HTMLInputElement | null | undefined. Adding null as a default value is better, since the returned value is inferred asHTMLInputElement | nulldue to the signaturefunction useRef<T>(initialValue: T | null): RefObject<T>;.I ran into this issue because I swapped the
<TextInput />in the<UpdatePasswordForm />component with a different input component (https://ui.shadcn.com/docs/components/input), which caused an error when passing therefdown to the new component. Adding null as the default value fixed that issue.