Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[WIP] Clarify the difference in active vs valid states #511
Been using this on my latest project and found it fantastic to work with.
One hurdle I ran into was understanding the difference in
Unless I am missing a potential state a subscription can be in - it seems that these methods will always return the same thing. The tests in this PR also pass - which confirm the results in the table.
My thinking is that an "active" subscription is one that you are going to make money off - i.e. it is going to renew.
A "valid" subscription is any subscription that has not ended, i.e. all active subscriptions and all subscriptions on a grace period.
Unless I'm missing something else - I think it would be good to fix the methods in the package and adjust the PR'd tests to match.
If you agree with my thinking let me know and I'll submit the fixes for you - otherwise I'm more than happy to adjust with your guidance on what
This has been submitted to
I don't think