Remove incorrect Builder type hint in relationship load callbacks #10874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Argument laravel#1 ($query) must be of type Illuminate\Database\Eloquent\Builder, Illuminate\Database\Eloquent\Relations\BelongsToMany given
shaedrich
reviewed
Oct 23, 2025
|
|
||
| ```php | ||
| $author->load(['books' => function (Builder $query) { | ||
| $author->load(['books' => function ($query) { |
Contributor
There was a problem hiding this comment.
Why not
Suggested change
| $author->load(['books' => function ($query) { | |
| $author->load(['books' => function (BelongsToMany $query) { |
then?
Contributor
There was a problem hiding this comment.
Another option would be
Suggested change
| $author->load(['books' => function ($query) { | |
| $author->load(['books' => function (\Illuminate\Contracts\Database\Eloquent\Builder $query) { |
Contributor
Author
There was a problem hiding this comment.
I am not sure about this, because the same callback pattern can be used for HasMany as well.
And while the 2nd suggestion removes the type error mentioned above, it breaks IDE autocompletion (Undefined method 'where').
What about \Illuminate\Database\Eloquent\Relations\Relation ?
Contributor
There was a problem hiding this comment.
Yeah, Relation works 👍🏻
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Laravel’s
load()method passes a relationship instance (e.g.,BelongsToMany,HasMany, etc.) to the callback, not aBuilder.As a result, using
Builder $querycauses a type error similar to: