fixed blade templating anchor and top link and insert query examples #113

Closed
wants to merge 3 commits into from

4 participants

@briankiewel

No description provided.

@briankiewel

added 996c4b6 to fix issue #102

@daylerees
The Laravel PHP Framework member

As with the commas you removed above, this line doesn't need it. Could you remove it for merge please :)

If you're talking about line 192 & 200 I'd say removing them was a good idea even if the code works fine with them.
Having commas there suggests, at least to me, that you can add another set of data without encapsulating the whole thing in an array. - The exact error this pull corrects.

As Arvid mentions, the comma on this line was to indicate that addtl datasets could be passed in. The prev commas were removed because they caused errors during execution. If you would prefer the comma gone here I'll remove it but my inclination would be to leave it to show more arrays can follow.

It seems I read Dayle's comment a bit sloppily. I do agree with Dayle that the last comma on line 210 should be removed, even though the code still works with it.
Anyone who's going to write this code will understand that you can add another array, no need to keep the comma.

Removed in commit 34ba872

@taylorotwell
The Laravel PHP Framework member

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment