Skip to content

Conversation

@ericnkatz
Copy link
Contributor

This is hopefully a clarity fix in reference to issue #1341. This will help beginners follow through instructions provided from Option 1 in launching their Homestead without PHP being installed on their host computer.

@adfaklsdjf
Copy link

Please note I commented on #1341 in an attempt to better explain how beginners can run into pitfalls with the current document.

@joelclermont
Copy link
Contributor

@ericnkatz This approach will still fail because the homestead script requires two dependencies that are installed via composer, which requires PHP. In order to truly eliminate any need for PHP on the host, you'd have to refactor all the instructions that reference homestead commands to use vagrant commands.

@ericnkatz
Copy link
Contributor Author

@joelclermont the idea is option 1 doesn't actually use the php pieces of the homestead script. It only uses the init.sh script that just creates the ~/.homestead directory and copies the contents of stub to that new directory.

If you followed option 1 you should never be running any homestead * commands in your terminal. In #1341, @adfaklsdjf mentioned that I thought the most clear route would be to create two completely separate instruction pages but I tried being minimally invasive in my PR.

@taylorotwell
Copy link
Member

The 5.1 docs already only present the manual Git way as the only installation option as I really think it's probably the better option long run.

@taylorotwell
Copy link
Member

I went ahead and just made the 5.1 Homestead docs the 5.0 docs as well.

@joelclermont
Copy link
Contributor

@taylorotwell Removing the composer installation instructions simplifies things quite a bit. Thanks! So with this recommended approach, you'd never use the homestead command, nor install any of the composer requirements for the homestead command.

I'm just thinking this through: Is there any value then in still having the homestead script and the composer dependencies and all the custom commands in src? It seems like if that's all still going to be there, we should have some note explaining that if you have PHP on the host box, you can composer install and use the homestead commands (possibly even adding it to your path)? If that's not recommended at all, then maybe drop those unused extras for simplicity?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants