Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add phpUnit configurationFile option #259

Merged
merged 1 commit into from Aug 25, 2015

Conversation

@jordonbaade
Copy link
Contributor

commented Aug 21, 2015

for gulp-phpunit.

Fixes #229 once mikeerickson/gulp-phpunit#26 is merged.

A recent gulp-phpunit commit gives priority to gulp.src() files for generating the specific command to run. In this case 'config.testing.phpUnit.path + '/*_/_Test.php' was given causing the error to fire as phpunit is looking for an xml file.

While gulp-phpunit has an option to use a file path string set on option.configurationFile, Elixir did not have this option set, and gulp-phpunit would ignore that completely anyway with the priority this way.

With my commit to gulp-phpunit the configurationFile will take priority as long it is set for gulp-phpunit's options..

JeffreyWay added a commit that referenced this pull request Aug 25, 2015

Merge pull request #259 from jordonbaade/patch-2
Add phpUnit configurationFile option

@JeffreyWay JeffreyWay merged commit 0ec0672 into laravel:master Aug 25, 2015

@JeffreyWay

This comment has been minimized.

Copy link
Contributor

commented Aug 25, 2015

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.