This repository has been archived by the owner on Mar 31, 2020. It is now read-only.
Add phpUnit configurationFile option #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffreyWay
added a commit
that referenced
this pull request
Aug 25, 2015
Add phpUnit configurationFile option
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for gulp-phpunit.
Fixes #229 once mikeerickson/gulp-phpunit#26 is merged.
A recent gulp-phpunit commit gives priority to gulp.src() files for generating the specific command to run. In this case 'config.testing.phpUnit.path + '/*_/_Test.php' was given causing the error to fire as phpunit is looking for an xml file.
While gulp-phpunit has an option to use a file path string set on option.configurationFile, Elixir did not have this option set, and gulp-phpunit would ignore that completely anyway with the priority this way.
With my commit to gulp-phpunit the configurationFile will take priority as long it is set for gulp-phpunit's options..