Skip to content
This repository has been archived by the owner. It is now read-only.

Add phpUnit configurationFile option #259

Merged
merged 1 commit into from Aug 25, 2015
Merged

Add phpUnit configurationFile option #259

merged 1 commit into from Aug 25, 2015

Conversation

jordonbaade
Copy link
Contributor

@jordonbaade jordonbaade commented Aug 21, 2015

for gulp-phpunit.

Fixes #229 once mikeerickson/gulp-phpunit#26 is merged.

A recent gulp-phpunit commit gives priority to gulp.src() files for generating the specific command to run. In this case 'config.testing.phpUnit.path + '/*_/_Test.php' was given causing the error to fire as phpunit is looking for an xml file.

While gulp-phpunit has an option to use a file path string set on option.configurationFile, Elixir did not have this option set, and gulp-phpunit would ignore that completely anyway with the priority this way.

With my commit to gulp-phpunit the configurationFile will take priority as long it is set for gulp-phpunit's options..

JeffreyWay added a commit that referenced this issue Aug 25, 2015
Add phpUnit configurationFile option
@JeffreyWay JeffreyWay merged commit 0ec0672 into laravel:master Aug 25, 2015
@JeffreyWay
Copy link
Contributor

@JeffreyWay JeffreyWay commented Aug 25, 2015

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants