Switch to Str helper functions

Persaeus · taylorotwell · commit 0099591d63c5 · 2020-04-23T09:26:12.000-05:00
diff --git a/src/Illuminate/Http/RedirectResponse.php b/src/Illuminate/Http/RedirectResponse.php
@@ -157,7 +157,7 @@ public function withFragmentIdentifier(string $fragmentIdentifier)
         $this->withoutFragmentIdentifier();
 
         // Strip superfluous "#" from the beginning of the fragment identifier
-        $fragmentIdentifier = preg_replace('/^#/', '', $fragmentIdentifier);
+        $fragmentIdentifier = Str::after($fragmentIdentifier, '#');
 
         return $this->setTargetUrl($this->getTargetUrl()."#$fragmentIdentifier");
     }
@@ -169,7 +169,7 @@ public function withFragmentIdentifier(string $fragmentIdentifier)
      */
     public function withoutFragmentIdentifier()
     {
-        return $this->setTargetUrl(explode('#', $this->getTargetUrl(), 2)[0]);
+        return $this->setTargetUrl(Str::before($this->getTargetUrl(), '#'));
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -157,7 +157,7 @@ public function withFragmentIdentifier(string $fragmentIdentifier)`
`157`	`157`	`$this->withoutFragmentIdentifier();`
`158`	`158`
`159`	`159`	`// Strip superfluous "#" from the beginning of the fragment identifier`
`160`		`- $fragmentIdentifier = preg_replace('/^#/', '', $fragmentIdentifier);`
	`160`	`+ $fragmentIdentifier = Str::after($fragmentIdentifier, '#');`
`161`	`161`
`162`	`162`	`return $this->setTargetUrl($this->getTargetUrl()."#$fragmentIdentifier");`
`163`	`163`	`}`
`@@ -169,7 +169,7 @@ public function withFragmentIdentifier(string $fragmentIdentifier)`
`169`	`169`	`*/`
`170`	`170`	`public function withoutFragmentIdentifier()`
`171`	`171`	`{`
`172`		`- return $this->setTargetUrl(explode('#', $this->getTargetUrl(), 2)[0]);`
	`172`	`+ return $this->setTargetUrl(Str::before($this->getTargetUrl(), '#'));`
`173`	`173`	`}`
`174`	`174`
`175`	`175`	`/**`