Skip to content

Commit 44c2a8d

Browse files
committed
formatting and add test
1 parent 6aa80e7 commit 44c2a8d

File tree

2 files changed

+13
-2
lines changed

2 files changed

+13
-2
lines changed

src/Illuminate/Container/BoundMethod.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ protected static function addDependencyForCallParameter($container, $parameter,
171171
} elseif ($parameter->isDefaultValueAvailable()) {
172172
$dependencies[] = $parameter->getDefaultValue();
173173
} elseif (! $parameter->isOptional() && ! array_key_exists($parameter->name, $parameters)) {
174-
$message = "Unresolvable dependency resolving [$parameter] in class {$parameter->getDeclaringClass()->getName()}";
174+
$message = "Unable to resolve dependency [{$parameter}] in class {$parameter->getDeclaringClass()->getName()}";
175175

176176
throw new BindingResolutionException($message);
177177
}

tests/Container/ContainerCallTest.php

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -172,11 +172,22 @@ public function testCallWithCallableObject()
172172
public function testCallWithoutRequiredParamsThrowsException()
173173
{
174174
$this->expectException(BindingResolutionException::class);
175-
$this->expectExceptionMessage('Unresolvable dependency resolving [Parameter #0 [ <required> $foo ]] in class Illuminate\Tests\Container\ContainerTestCallStub');
175+
$this->expectExceptionMessage('Unable to resolve dependency [Parameter #0 [ <required> $foo ]] in class Illuminate\Tests\Container\ContainerTestCallStub');
176176

177177
$container = new Container;
178178
$container->call(ContainerTestCallStub::class.'@unresolvable');
179179
}
180+
181+
public function testCallWithoutRequiredParamsOnClosureThrowsException()
182+
{
183+
$this->expectException(BindingResolutionException::class);
184+
$this->expectExceptionMessage('Unable to resolve dependency [Parameter #0 [ <required> $foo ]] in class Illuminate\Tests\Container\ContainerCallTest');
185+
186+
$container = new Container;
187+
$foo = $container->call(function ($foo, $bar = 'default') {
188+
return $foo;
189+
});
190+
}
180191
}
181192

182193
class ContainerTestCallStub

0 commit comments

Comments
 (0)