formatting

laravel · Dec 18, 2020 · 49b3ce0 · 49b3ce0
1 parent 5739cd5
commit 49b3ce0
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 9 deletions.
diff --git a/src/Illuminate/Database/Eloquent/Relations/Concerns/InteractsWithPivotTable.php b/src/Illuminate/Database/Eloquent/Relations/Concerns/InteractsWithPivotTable.php
@@ -124,20 +124,18 @@ public function sync($ids, $detaching = true)
     }
 
     /**
-     * Sync the intermediate tables with a list of IDs or collection of models with default values.
+     * Sync the intermediate tables with a list of IDs or collection of models with the given pivot values.
      *
      * @param  \Illuminate\Support\Collection|\Illuminate\Database\Eloquent\Model|array  $ids
+     * @param  array  $values
      * @param  bool  $detaching
-     * @param  array  $defaults
      * @return array
      */
-    public function syncWithPivotDefaults($ids, array $defaults, bool $detaching = true)
+    public function syncWithPivotValues($ids, array $values, bool $detaching = true)
     {
-        $idsWithDefaults = collect($this->parseIds($ids))->mapWithKeys(function ($id) use ($defaults) {
-            return [$id => $defaults];
-        });
-
-        return $this->sync($idsWithDefaults, $detaching);
+        return $this->sync(collect($this->parseIds($ids))->mapWithKeys(function ($id) use ($values) {
+            return [$id => $values];
+        }), $detaching);
     }
 
     /**

diff --git a/tests/Database/DatabaseEloquentBelongsToManySyncReturnValueTypeTest.php b/tests/Database/DatabaseEloquentBelongsToManySyncReturnValueTypeTest.php
@@ -101,7 +101,7 @@ public function testSyncWithPivotDefaultsReturnValueType()
         $user = BelongsToManySyncTestTestUser::query()->first();
         $articleIDs = BelongsToManySyncTestTestArticle::all()->pluck('id')->toArray();
 
-        $changes = $user->articles()->syncWithPivotDefaults($articleIDs, ['visible' => true]);
+        $changes = $user->articles()->syncWithPivotValues($articleIDs, ['visible' => true]);
 
         collect($changes['attached'])->each(function ($id) {
             $this->assertSame(gettype($id), (new BelongsToManySyncTestTestArticle)->getKeyType());