Skip to content

Commit 5ea388d

Browse files
committed
revert change
1 parent c39ec48 commit 5ea388d

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

src/Illuminate/Filesystem/Filesystem.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -207,7 +207,7 @@ public function replace($path, $content)
207207
$tempPath = tempnam(dirname($path), basename($path));
208208

209209
// Fix permissions of tempPath because `tempnam()` creates it with permissions set to 0600...
210-
chmod($tempPath, 0666 - umask());
210+
chmod($tempPath, 0777 - umask());
211211

212212
file_put_contents($tempPath, $content);
213213

tests/Filesystem/FilesystemTest.php

+6-6
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ public function testFilePermissionRestoredAfterReplace()
103103
$filesystem = new Filesystem;
104104
$filesystem->replace($tempFile, 'Hello World');
105105
$umaskValue = umask();
106-
$permissionValueInDecimal = (int) base_convert('666', 8, 10);
106+
$permissionValueInDecimal = (int) base_convert('777', 8, 10);
107107
$actualPermission = $permissionValueInDecimal - $umaskValue;
108108
$this->assertEquals($actualPermission, $this->getFilePermissions($tempFile));
109109
}
@@ -124,30 +124,30 @@ public function testReplaceWhenUnixSymlinkExists()
124124
chmod($symlinkDir, 0555);
125125

126126
// Test with a weird non-standard umask.
127-
$umask = 0031;
127+
$umask = 0131;
128128
$originalUmask = umask($umask);
129129

130130
$filesystem = new Filesystem;
131131

132132
// Test replacing non-existent file.
133133
$filesystem->replace($tempFile, 'Hello World');
134134
$this->assertStringEqualsFile($tempFile, 'Hello World');
135-
$this->assertEquals($umask, 0666 - $this->getFilePermissions($tempFile));
135+
$this->assertEquals($umask, 0777 - $this->getFilePermissions($tempFile));
136136

137137
// Test replacing existing file.
138138
$filesystem->replace($tempFile, 'Something Else');
139139
$this->assertStringEqualsFile($tempFile, 'Something Else');
140-
$this->assertEquals($umask, 0666 - $this->getFilePermissions($tempFile));
140+
$this->assertEquals($umask, 0777 - $this->getFilePermissions($tempFile));
141141

142142
// Test replacing symlinked file.
143143
$filesystem->replace($symlink, 'Yet Something Else Again');
144144
$this->assertStringEqualsFile($tempFile, 'Yet Something Else Again');
145-
$this->assertEquals($umask, 0666 - $this->getFilePermissions($tempFile));
145+
$this->assertEquals($umask, 0777 - $this->getFilePermissions($tempFile));
146146

147147
umask($originalUmask);
148148

149149
// Reset changes to symlink_dir
150-
chmod($symlinkDir, 0666 - $originalUmask);
150+
chmod($symlinkDir, 0777 - $originalUmask);
151151
}
152152

153153
public function testSetChmod()

0 commit comments

Comments
 (0)