formatting

Author: taylorotwell

Diff for: src/Illuminate/Http/RedirectResponse.php

@@ -146,28 +146,23 @@ public function withErrors($provider, $key = 'default')
     }
 
     /**
-     * Add fragment identifier to the url.
+     * Add a fragment identifier to the URL.
      *
-     * @param  string  $fragmentIdentifier
+     * @param  string  $fragment
      * @return $this
      */
-    public function withFragmentIdentifier($fragmentIdentifier)
+    public function withFragment($fragment)
     {
-        // Remove any existing fragment identifier
-        $this->withoutFragmentIdentifier();
-
-        // Strip superfluous "#" from the beginning of the fragment identifier
-        $fragmentIdentifier = Str::after($fragmentIdentifier, '#');
-
-        return $this->setTargetUrl($this->getTargetUrl()."#$fragmentIdentifier");
+        return $this->withoutFragment()
+                ->setTargetUrl($this->getTargetUrl().'#'.Str::after($fragment, '#'));
     }
 
     /**
-     * Remove any fragment identifier from the response url.
+     * Remove any fragment identifier from the response URL.
      *
      * @return $this
      */
-    public function withoutFragmentIdentifier()
+    public function withoutFragment()
     {
         return $this->setTargetUrl(Str::before($this->getTargetUrl(), '#'));
     }

Diff for: tests/Http/HttpRedirectResponseTest.php

@@ -56,13 +56,13 @@ public function testFragmentIdentifierOnRedirect()
     {
         $response = new RedirectResponse('foo.bar');
 
-        $response->withFragmentIdentifier('foo');
+        $response->withFragment('foo');
         $this->assertSame('foo', parse_url($response->getTargetUrl(), PHP_URL_FRAGMENT));
 
-        $response->withFragmentIdentifier('#bar');
+        $response->withFragment('#bar');
         $this->assertSame('bar', parse_url($response->getTargetUrl(), PHP_URL_FRAGMENT));
 
-        $response->withoutFragmentIdentifier();
+        $response->withoutFragment();
         $this->assertNull(parse_url($response->getTargetUrl(), PHP_URL_FRAGMENT));
     }