formatting

Author: taylorotwell

Diff for: src/Illuminate/Support/Testing/Fakes/BusFake.php

@@ -64,7 +64,7 @@ public function __construct(QueueingDispatcher $dispatcher, $jobsToFake = [])
     public function assertDispatched($command, $callback = null)
     {
         if ($command instanceof Closure) {
-            [$command, $callback] = [$this->firstParameterType($command), $command];
+            [$command, $callback] = [$this->firstClosureParameterType($command), $command];
         }
 
         if (is_numeric($callback)) {
@@ -106,7 +106,7 @@ public function assertDispatchedTimes($command, $times = 1)
     public function assertNotDispatched($command, $callback = null)
     {
         if ($command instanceof Closure) {
-            [$command, $callback] = [$this->firstParameterType($command), $command];
+            [$command, $callback] = [$this->firstClosureParameterType($command), $command];
         }
 
         PHPUnit::assertTrue(
@@ -126,7 +126,7 @@ public function assertNotDispatched($command, $callback = null)
     public function assertDispatchedAfterResponse($command, $callback = null)
     {
         if ($command instanceof Closure) {
-            [$command, $callback] = [$this->firstParameterType($command), $command];
+            [$command, $callback] = [$this->firstClosureParameterType($command), $command];
         }
 
         if (is_numeric($callback)) {
@@ -166,7 +166,7 @@ public function assertDispatchedAfterResponseTimes($command, $times = 1)
     public function assertNotDispatchedAfterResponse($command, $callback = null)
     {
         if ($command instanceof Closure) {
-            [$command, $callback] = [$this->firstParameterType($command), $command];
+            [$command, $callback] = [$this->firstClosureParameterType($command), $command];
         }
 
         PHPUnit::assertCount(

Diff for: src/Illuminate/Support/Testing/Fakes/EventFake.php

@@ -57,7 +57,7 @@ public function __construct(Dispatcher $dispatcher, $eventsToFake = [])
     public function assertDispatched($event, $callback = null)
     {
         if ($event instanceof Closure) {
-            [$event, $callback] = [$this->firstParameterType($event), $event];
+            [$event, $callback] = [$this->firstClosureParameterType($event), $event];
         }
 
         if (is_int($callback)) {
@@ -97,7 +97,7 @@ public function assertDispatchedTimes($event, $times = 1)
     public function assertNotDispatched($event, $callback = null)
     {
         if ($event instanceof Closure) {
-            [$event, $callback] = [$this->firstParameterType($event), $event];
+            [$event, $callback] = [$this->firstClosureParameterType($event), $event];
         }
 
         PHPUnit::assertCount(

Diff for: src/Illuminate/Support/Testing/Fakes/MailFake.php

@@ -46,7 +46,7 @@ class MailFake implements Factory, Mailer, MailQueue
     public function assertSent($mailable, $callback = null)
     {
         if ($mailable instanceof Closure) {
-            [$mailable, $callback] = [$this->firstParameterType($mailable), $mailable];
+            [$mailable, $callback] = [$this->firstClosureParameterType($mailable), $mailable];
         }
 
         if (is_numeric($callback)) {
@@ -121,7 +121,7 @@ public function assertNothingSent()
     public function assertQueued($mailable, $callback = null)
     {
         if ($mailable instanceof Closure) {
-            [$mailable, $callback] = [$this->firstParameterType($mailable), $mailable];
+            [$mailable, $callback] = [$this->firstClosureParameterType($mailable), $mailable];
         }
 
         if (is_numeric($callback)) {

Diff for: src/Illuminate/Support/Testing/Fakes/NotificationFake.php

@@ -56,7 +56,7 @@ public function assertSentTo($notifiable, $notification, $callback = null)
         }
 
         if ($notification instanceof Closure) {
-            [$notification, $callback] = [$this->firstParameterType($notification), $notification];
+            [$notification, $callback] = [$this->firstClosureParameterType($notification), $notification];
         }
 
         if (is_numeric($callback)) {
@@ -112,7 +112,7 @@ public function assertNotSentTo($notifiable, $notification, $callback = null)
         }
 
         if ($notification instanceof Closure) {
-            [$notification, $callback] = [$this->firstParameterType($notification), $notification];
+            [$notification, $callback] = [$this->firstClosureParameterType($notification), $notification];
         }
 
         PHPUnit::assertCount(

Diff for: src/Illuminate/Support/Testing/Fakes/QueueFake.php

@@ -30,7 +30,7 @@ class QueueFake extends QueueManager implements Queue
     public function assertPushed($job, $callback = null)
     {
         if ($job instanceof Closure) {
-            [$job, $callback] = [$this->firstParameterType($job), $job];
+            [$job, $callback] = [$this->firstClosureParameterType($job), $job];
         }
 
         if (is_numeric($callback)) {
@@ -71,7 +71,7 @@ protected function assertPushedTimes($job, $times = 1)
     public function assertPushedOn($queue, $job, $callback = null)
     {
         if ($job instanceof Closure) {
-            [$job, $callback] = [$this->firstParameterType($job), $job];
+            [$job, $callback] = [$this->firstClosureParameterType($job), $job];
         }
 
         return $this->assertPushed($job, function ($job, $pushedQueue) use ($callback, $queue) {
@@ -193,7 +193,7 @@ protected function isChainOfObjects($chain)
     public function assertNotPushed($job, $callback = null)
     {
         if ($job instanceof Closure) {
-            [$job, $callback] = [$this->firstParameterType($job), $job];
+            [$job, $callback] = [$this->firstClosureParameterType($job), $job];
         }
 
         PHPUnit::assertCount(

Diff for: src/Illuminate/Support/Traits/ReflectsClosures.php

@@ -10,14 +10,14 @@
 trait ReflectsClosures
 {
     /**
-     * Get the class types of the parameters of the given closure.
+     * Get the class names / types of the parameters of the given Closure.
      *
      * @param  Closure  $closure
      * @return array
      *
      * @throws \ReflectionException
      */
-    protected function parameterTypes(Closure $closure)
+    protected function closureParameterTypes(Closure $closure)
     {
         $reflection = new ReflectionFunction($closure);
 
@@ -31,23 +31,23 @@ protected function parameterTypes(Closure $closure)
     }
 
     /**
-     * Get the class of the first parameter of the given closure.
+     * Get the class name of the first parameter of the given Closure.
      *
      * @param  Closure  $closure
      * @return string
      *
      * @throws \ReflectionException|\RunTimeException
      */
-    protected function firstParameterType(Closure $closure)
+    protected function firstClosureParameterType(Closure $closure)
     {
-        $types = $this->parameterTypes($closure);
+        $types = $this->closureParameterTypes($closure);
 
         if (! $types) {
-            throw new RunTimeException('The given closure has no parameters');
+            throw new RunTimeException('The given Closure has no parameters.');
         }
 
         if ($types[0] === null) {
-            throw new RunTimeException('The first parameter of the given closure has no class type hint');
+            throw new RunTimeException('The first parameter of the given Closure is missing a type hint.');
         }
 
         return $types[0];

Diff for: tests/Support/SupportReflectsClosuresTest.php

@@ -78,12 +78,12 @@ class ReflectsClosuresClass
 
     public static function reflect($closure)
     {
-        return (new static)->parameterTypes($closure);
+        return (new static)->closureParameterTypes($closure);
     }
 
     public static function reflectFirst($closure)
     {
-        return (new static)->firstParameterType($closure);
+        return (new static)->firstClosureParameterType($closure);
     }
 }