Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
/
Hi,
I came across a strange issue when using eloquent and pagination as standalone.
The url was /users and the paginated results were /users/?page=<no> .
/users
/users/?page=<no>
Please note that the resolver was
Illuminate\Pagination\Paginator::currentPathResolver(function () { return '/users'; });
Further digging to find the issue, I noticed something.
https://github.com/illuminate/pagination/blob/27c621a800333d466b7be09230a301495e14f596/LengthAwarePaginator.php#L50
$this->path = $this->path != '/' ? rtrim($this->path, '/') : $this->path;
Isn't it supposed to just return me the url path I have set. It is trimming and appending the / . That seems I don't have a way to resolve this.
Can I send a PR removing the appending of / .
Thank you.
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Hi,
I came across a strange issue when using eloquent and pagination as standalone.
The url was
/users
and the paginated results were/users/?page=<no>
.Please note that the resolver was
Further digging to find the issue, I noticed something.
https://github.com/illuminate/pagination/blob/27c621a800333d466b7be09230a301495e14f596/LengthAwarePaginator.php#L50
Isn't it supposed to just return me the url path I have set. It is trimming and appending the
/
. That seems I don't have a way to resolve this.Can I send a PR removing the appending of
/
.Thank you.
The text was updated successfully, but these errors were encountered: