Paginator : LengthAwarePaginator appending `/` in url #10909

Closed
harikt opened this Issue Nov 12, 2015 · 0 comments

Comments

Projects
None yet
1 participant
@harikt
Contributor

harikt commented Nov 12, 2015

Hi,

I came across a strange issue when using eloquent and pagination as standalone.

The url was /users and the paginated results were /users/?page=<no> .

Please note that the resolver was

Illuminate\Pagination\Paginator::currentPathResolver(function () {
    return '/users';
});

Further digging to find the issue, I noticed something.

https://github.com/illuminate/pagination/blob/27c621a800333d466b7be09230a301495e14f596/LengthAwarePaginator.php#L50

$this->path = $this->path != '/' ? rtrim($this->path, '/') : $this->path;

Isn't it supposed to just return me the url path I have set. It is trimming and appending the / . That seems I don't have a way to resolve this.

Can I send a PR removing the appending of / .

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment