Undefined index: domain in SessionServiceProvider #605

Closed
RobBrazier opened this Issue Mar 17, 2013 · 4 comments

Comments

Projects
None yet
2 participants
@RobBrazier

In SessionServiceProvider, line 124, I am getting an undefined index: domain. The context code is

/**
     * Create a session cookie based on the given config.
     *
     * @param  Illuminate\Session\Store  $session
     * @param  array  $config
     * @return Symfony\Component\HttpFoundation\Cookie
     */
    public function makeCookie($session, $config)
    {
        $app = $this->app;

        return $session->getCookie(

            $app['cookie'], $config['cookie'], $config['lifetime'], $config['path'], $config['domain']

        );
    }

and the last $config['domain'] is the one that is causing the problems. Originally I was able to just remove it to temporarily solve the issue, but now $session->getCookie() requires 5 parameters, and I'm not really sure what $config['domain'] is, so that I would be able to try to fix it, could someone enlighten me, as I'm a bit stumped?

Also, just looking at the source of getCookie(), it doesn't look like it takes 5 parameters, which makes me even more confused D:

@Anahkiasen

This comment has been minimized.

Show comment
Hide comment
@Anahkiasen

Anahkiasen Mar 17, 2013

Contributor

Did you update your application's skeleton to the latest laravel/laravel ?

Contributor

Anahkiasen commented Mar 17, 2013

Did you update your application's skeleton to the latest laravel/laravel ?

@RobBrazier

This comment has been minimized.

Show comment
Hide comment
@RobBrazier

RobBrazier Mar 17, 2013

oh no, I haven't, that would probably be why, i've just been updating laravel/framework. I'll try that, would it just be copying the files over, as it's not managed by composer?

oh no, I haven't, that would probably be why, i've just been updating laravel/framework. I'll try that, would it just be copying the files over, as it's not managed by composer?

@Anahkiasen

This comment has been minimized.

Show comment
Hide comment
@Anahkiasen

Anahkiasen Mar 17, 2013

Contributor

Well, pretty much yeah. That or if your repository is based or has merged at one point the laravel/laravel repository you can just pull from it and it will merge the changes but you may have conflicts.

Contributor

Anahkiasen commented Mar 17, 2013

Well, pretty much yeah. That or if your repository is based or has merged at one point the laravel/laravel repository you can just pull from it and it will merge the changes but you may have conflicts.

@RobBrazier

This comment has been minimized.

Show comment
Hide comment
@RobBrazier

RobBrazier Mar 17, 2013

I ended up just doing a bodge job again, temporarily, as taylor added the html and form service providers to app.php (05cb4ca2765b2e8769d764d95013f2476265b558), with no actual classes to go with it at the moment. I'll wait until those are added and then try updating the skeleton, as it's throwing a lot of errors at me at the moment :/

I ended up just doing a bodge job again, temporarily, as taylor added the html and form service providers to app.php (05cb4ca2765b2e8769d764d95013f2476265b558), with no actual classes to go with it at the moment. I'll wait until those are added and then try updating the skeleton, as it's throwing a lot of errors at me at the moment :/

@RobBrazier RobBrazier closed this Mar 17, 2013

@RobBrazier RobBrazier reopened this Mar 17, 2013

@RobBrazier RobBrazier closed this Mar 17, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment