[5.1] Fix timestamps on update #12403
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #10028 where timestamps are updated even if
['timestamps' => false]
is passed to thesave()
method.The easiest solution would be to simply pass the
$options
array to the update method on theBuilder
but since that would be a breaking change (someone may be extending the Builder) I added a new flag$shouldUpdateTimestamps
that is set tofalse
if timestamps were disabled.