[5.3] Fix broken travis-ci test #12623
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Yeh. We're going to wait for symfony to respond first. |
Member
|
Symfony is going to revert it. |
Contributor
Author
|
Nice! Oh, I notice that you have post the problem to them before. I should check it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The symfony http-foundation update their
Symfony\Component\HttpFoundation\JsonResponse@setData.The original is
public function setData($data = array()), and after 2/2 they update to
public function setData($data = array(), $preEncoded = false)So, the travis-cy can't not pass. I add
$preEncodedto PR, however the preEncoded is useless in laravel framework case.If Symfony change their class back, the PR can be ignored.