Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.3] Add fluent email priority setter #15178

Merged
merged 1 commit into from
Aug 31, 2016
Merged

[5.3] Add fluent email priority setter #15178

merged 1 commit into from
Aug 31, 2016

Conversation

KKSzymanowski
Copy link
Contributor

Regarding #15153

@KKSzymanowski
Copy link
Contributor Author

One thing. I haven't found any tests for the Mailable class.
I didn't know where to put tests for this functionality so I didn't write any.

@GrahamCampbell GrahamCampbell changed the title Add fluent email priority setter [5.3] Add fluent email priority setter Aug 31, 2016
@@ -341,6 +341,23 @@ public function replyTo($address, $name = null)
}

/**
* Set the priority of this message.
*
* The value is an integer where 1 is the highest priority and 5 is the lowest.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there constants for these inside swiftmailer?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't found any.

This is the SwiftMailer method header:

/**
 * Set the priority of this message.
 *
 * The value is an integer where 1 is the highest priority and 5 is the lowest.
 *
 * @param int $priority
 *
 * @return Swift_Mime_SimpleMessage
 */
public function setPriority($priority);

@taylorotwell taylorotwell merged commit 0311c15 into laravel:5.3 Aug 31, 2016
@KKSzymanowski
Copy link
Contributor Author

There are methods to and bcc on Illuminate\Mail\Mailer(so also on Mail facade). Should I add priority method to Illuminate\Mail\Mailer and to Illuminate\Mail\MailableMailer classes?

Also, why there's no cc method on Illuminate\Mail\Mailer?

@KKSzymanowski KKSzymanowski deleted the feature/fluent-mail-priority branch August 31, 2016 15:08
@KKSzymanowski
Copy link
Contributor Author

@taylorotwell, @GrahamCampbell
What about Mail facade? Should I add the priority(or withPriority) method there as well or leave it like it is?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants