New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[5.3] Fix regression in save(touch) option" #16660

Merged
merged 1 commit into from Dec 5, 2016

Conversation

Projects
None yet
2 participants
@themsaid
Member

themsaid commented Dec 5, 2016

Reverts laravel/framework#15264

This feature doesn't work because the update method of Eloquent/Builder adds the updated_at column anyway, we already removed the timestamp option before #12617 based on this #12403 (comment)

To prevent touching the model timestamp we should use this instead:

$user->timestamps = false;

$user->save();

@taylorotwell taylorotwell merged commit 3b7181e into 5.3 Dec 5, 2016

4 checks passed

continuous-integration/styleci/pr The StyleCI analysis has passed
Details
continuous-integration/styleci/push The StyleCI analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@themsaid themsaid deleted the revert-15264-fix/save-touch-option branch Dec 5, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment