Skip to content

[5.4] fix an issue with slots when content is null - #18246

Merged
taylorotwell merged 1 commit into
laravel:5.4from
themsaid:fix/slots
Mar 8, 2017
Merged

[5.4] fix an issue with slots when content is null#18246
taylorotwell merged 1 commit into
laravel:5.4from
themsaid:fix/slots

Conversation

@themsaid

@themsaid themsaid commented Mar 7, 2017

Copy link
Copy Markdown
Member

In reference to #18234

if you do @slot('name', $variable) while $variable the code in else will be executed and output buffering will start causing the blade rendering to break.

@taylorotwell
taylorotwell merged commit aabfebe into laravel:5.4 Mar 8, 2017
@browner12

Copy link
Copy Markdown
Contributor

i think you may have missed a word or two in your explanation @themsaid so just to clear this up, this occurs when $variable is null?

@AlbertMarashi

Copy link
Copy Markdown

@browner12 yes correct, or "" I believe

@AlbertMarashi

Copy link
Copy Markdown

@themsaid will composer update fix this?

@browner12

Copy link
Copy Markdown
Contributor

you'll just have to wait until a new release is tagged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants