[5.4] add tap to query builder

[BrandonShar]

I've run into a few situations lately (mainly parsing filters from query strings) where I ended up using when(1, $callback).

To make this a bit cleaner, I added a tap method to query builder to mimic the behavior found in collections.

[taylorotwell]

Interesting, what were you using this for?

[BrandonShar]

I've been parsing filters out of the query string on api endpoints. A simplified example of code looks like this:

return User::when(true, function ($query) use ($request) {  
    foreach ($request->except('sort', 'page') as $param => $value) { 
        $query->where($param, $value); 
    } 
})->get();

[BrandonShar]

I'd love a cleaner way to filter by query params, but it would definitely require some discussion since the solution would likely be pretty opinionated.

[taylorotwell]

Gotcha.

[JosephSilber]

@BrandonShar BTW, you can pass an array directly to where:

return User::where($request->except('sort', 'page'))->get();

[BrandonShar]

@JosephSilber thanks for the advice, I'll keep that in mind. In this case though, I simplified my example a good bit. In my real use case, I check for things like * to indicate wild card and whether scopes exist for certain filters.