[5.4] Database Factory includes non-php files#18336
Merged
taylorotwell merged 2 commits intolaravel:5.4from Mar 14, 2017
Merged
[5.4] Database Factory includes non-php files#18336taylorotwell merged 2 commits intolaravel:5.4from
taylorotwell merged 2 commits intolaravel:5.4from
Conversation
eyJhb
changed the title
lucasmichot
reviewed
Mar 14, 2017
|
|
||
| if (is_dir($path)) { | ||
| foreach (Finder::create()->files()->in($path) as $file) { | ||
| if(pathinfo($file->getRealPath(), PATHINFO_EXTENSION) !== 'php') { |
Contributor
There was a problem hiding this comment.
Why not just Finder::create()->files()->name('*.php')->in($path) ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using a editor like emacs that creates eg. 'UserSeeder.php~' files, those files will get included as well as the correct 'UserSeeder.php' file.
This causes 'UserSeeder.php' to get overwritten with the 'UserSeeder.php~', which can cause a lot of confusion.