[5.4] fixing weird behaviour of Connection method#18356
Merged
taylorotwell merged 2 commits intolaravel:5.4from Mar 15, 2017
vikkio88:18209-Weird-behaviour-of-Connection
Merged
[5.4] fixing weird behaviour of Connection method#18356taylorotwell merged 2 commits intolaravel:5.4from vikkio88:18209-Weird-behaviour-of-Connection
taylorotwell merged 2 commits intolaravel:5.4from
vikkio88:18209-Weird-behaviour-of-Connection
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The method
getConfig()of connection class was working weirdly if you did pass null, you could still get the$this->configarray, but some warnings would be thrown.I add a default parameter and a check to avoid the error to be thrown.
PR added after speaking on twitter with @taylorotwell, was an honour sir 😄