[5.4] Output migration name before starting a migration or rollback#18379
Merged
Conversation
…rollback
Laravel shows the migration name when an UP or DOWN has finished, but not before it starts.
It would be useful to see the migration name before it starts, in the runUp and runDown methods.
I spent some time today trying to figure out why my simple migration was just hanging -- rebooting my VM and such, when it was actually a 10+ minute long migration a teammate had slipped in that was running before mine. Since there is no output until finished, I thought something was hanging.
It would have been useful to know that it was busy running THAT migration.
For language, I’d propose this:
```$this->note("<info>Rolling back:</info> {$file}");
$this->note("<info>Migrating:</info> {$file}");```
(to matched the ‘Rolled Back: ‘ and ‘Migrated: ' messages on completion.)
Member
|
There is a formatting difference where yours has the whole file path and the completed notification just has the basename style output. |
Contributor
Author
|
Thanks - I fixed that. I had tested on 5.3 where $file is what was displayed, and pulled the code from there. I changed this to $name to match. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Laravel shows the migration name as output when an UP or DOWN has finished, but does not show any output before starting either.
It would be useful to see the migration name before it starts, in the runUp and runDown methods.
I spent some time today trying to figure out why my simple migration was just hanging -- rebooting my VM and such, when it was actually a 10+ minute long migration a teammate had slipped in that was running before mine. Since there is no output until finished, I thought something was hanging as the cursor just sat below the command prompt with no indication of anything happening.
It would have been useful to know that it was busy running THAT migration.
For language, I’m propose this in this pull request:
(to matched the ‘Rolled Back: ‘ and ‘Migrated: ' messages that are show on completion.)