[5.4] Allow Validator extension to use array-style callable#18399
Merged
Conversation
Currently, a validator extension can be either a Closure or a string denoting a class and method. For complex validation scenarios, however, it's useful to be able to pass an object and method in the array-style callable format (i.e. [$object, $method] instead of "$class@$method").
| $callback = $this->extensions[$rule]; | ||
|
|
||
| if ($callback instanceof Closure) { | ||
| if ($callback instanceof Closure || is_array($callback)) { |
There was a problem hiding this comment.
I believe you can change this line into something like this: if (is_callable($callback)) {. And it will achieve the same result.
Contributor
Author
There was a problem hiding this comment.
Good point. I'll update the pull request.
adamthehutt
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, a validator extension can be either a Closure or a string denoting a class and method. For complex validation scenarios, however, it's useful to be able to pass an object and method in the array-style callable format (i.e. [$object, $method] instead of "$class@$method").