[5.4] Create a static "times" method on the collection - #18457
Merged
Conversation
JosephSilber
force-pushed
the
collection-range
branch
7 times, most recently
from
March 23, 2017 02:22
c2e28be to
c2c83b8
Compare
JosephSilber
force-pushed
the
collection-range
branch
3 times, most recently
from
March 23, 2017 02:27
5c07a42 to
7b08ced
Compare
Member
|
The name of the method needs work maybe? |
Contributor
Author
|
This is an each (plus a map). There's nothing stopping you from just ignoring everything else: Collection::times(5, function () {
echo 'I will be logged 5 times.';
}); |
Contributor
|
|
Contributor
|
Failing test: public function testTimesWithZeroMethod()
{
$this->assertEquals([], Collection::times(0, function ($number) {
return 'do-not-enter-'.$number;
})->all());
} |
Contributor
Author
|
Do we really have to check for that? And what if you pass it a negative number?
|
Contributor
|
Negative numbers do not make sense but if we I see a method called "times" and give a 0 as parameter I expect that it executes zero times |
JosephSilber
force-pushed
the
collection-range
branch
3 times, most recently
from
March 24, 2017 18:11
e4f21d6 to
2f03d11
Compare
JosephSilber
force-pushed
the
collection-range
branch
from
March 24, 2017 18:13
2f03d11 to
1939153
Compare
Contributor
Author
|
@jmarcher makes sense. Added it 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is extremely useful to whip up a quick list of stuff, whether in a test or in production:
You can also use it with factories, for example if you want sequential numbers: