[5.4] Wrong type of argument for formatRecordsList method in InteractsWithPivotTable trait.#18547
Merged
Conversation
Type for result of parseIds method. When using sync method and passing only one eloquent model as first argument Fatal error is thrown, because formatRecordsList accepts only arrays, but result of parseIds method is not casted to type like in (for example) in toggle method.
tillkruss
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using
syncmethod and passing only one eloquent model as first argumentFatal erroris thrown, becauseformatRecordsListaccepts only arrays, but result ofparseIdsmethod is not casted to type like intogglemethod.