[5.4] use same output style for jobs as migrations - #18773
Merged
Conversation
m1guelpf
approved these changes
Apr 11, 2017
Contributor
|
Would you mind adding tests for this? |
Contributor
Author
|
@tillkruss from what i can find, the current tests only check for the events being fired, nothing related to text output. |
Contributor
Author
|
And i currently do not see how a test would be written for this/wether it is required at all (the writeOutput function only gets called in the function i changed, from all the files in the entire framework) |
tillkruss
reviewed
Apr 11, 2017
| break; | ||
| case 'failed': | ||
| $this->output->writeln('<error>['.Carbon::now()->format('Y-m-d H:i:s').'] Failed:</error> '.$job->resolveName()); | ||
| break; |
Contributor
There was a problem hiding this comment.
Using str_pad() here, might make this more readable.
Contributor
Author
|
I'll refractor it in a moment, good point @tillkruss |
Contributor
Author
|
@tillkruss I have updated the code the best i could, is it more readable now? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See 2328c7a
And #18542