[5.4] Add the lazy method to replace the closure use in model factories#18823
Merged
Conversation
Member
|
Should I have to call ->create() after ->lazy()... would it be preferable to just say: |
…hen using model factories
Contributor
Author
|
@taylorotwell done! I thought about it after I submitted the PR 😅 |
gocanto
reviewed
Apr 24, 2017
gocanto
left a comment
Contributor
There was a problem hiding this comment.
Can I know what is the beneffit of returning a clause?
Contributor
Contributor
|
Yes @JosephSilber, I read your tweet as soon as it was posted. But, my question is related to the fact of returning a clausure. Why is there a reason for it? Pretty sure this is nor the place to ask this, but if it can be answered it would be nice. |
Contributor
|
Are you sure you read that tweet carefully? It clearly explains how, without the closure, you can end up with extra models that you did not necessarily mean to create.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following: #18499
I added the lazy method to delay the creation of models in the database in a more eloquent way:
What do you think?