Adds the ability to force a new connection to Redis - #18830
Merged
Conversation
Member
|
Sounds kinda more intuitive to have a disconnect() method like DB? |
Contributor
Author
|
I don't want to disconnect either connection. I actually need both connections to be active so I can continue to listen on one connection while interacting with Redis over the second connection. Some additional reports of similar needs on other frameworks, |
Member
|
Easier for me to just make |
Contributor
Author
|
👍 makes sense. Thank you. Would you like another PR based on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using Redis' SUBSCRIBE the recommendation is to open a second connection for any key modification you need to do. E.g. Laravel does not currently allow you to modify keys why subscribed, causing the following to error,
The exact error is,
This PR allows you to work around this by forcing a new connection to Redis, when necessary,
The need for a second connection is also stated here,
http://stackoverflow.com/questions/22668244/should-i-use-separate-connections-for-pub-and-sub-with-redis
Note, this could probably be more expressive with
Redis::newConnection()but I wanted to start here.