[5.4] JsonResponse unsupported type error handling if flag set - #18917
Merged
Conversation
| */ | ||
| protected function hasJsonError($jsonLastError) | ||
| { | ||
| return $jsonLastError !== JSON_ERROR_NONE && ($jsonLastError !== JSON_ERROR_UNSUPPORTED_TYPE || ! ($this->encodingOptions & JSON_PARTIAL_OUTPUT_ON_ERROR)); |
Member
There was a problem hiding this comment.
This line is pretty hard to read. Is it possible to break it down into something simpler?
Contributor
Author
There was a problem hiding this comment.
@taylorotwell you're absolutely right, please check it ;)
+ handling JSON_PARTIAL_OUTPUT_ON_ERROR flag (e.g. w/ resource)
Member
|
I'm sorry this conditional is still basically unreadable. I think it needs some of the not conditions reversed and maybe the whole method renamed. |
Member
|
I reversed the whole conditional and renamed the method. Much easier to understand. Thanks. |
Contributor
Author
|
Thank you @taylorotwell! ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
Illuminate\Http\JsonResponsedoes not support JSON_PARTIAL_OUTPUT_ON_ERROR flag check onjson_encode()error.If the
JsonResponseconstructor$dataargument contains a resource (maybe deep inside in an error stack -$exception->getTrace()) there is anInvalidArgumentExceptionthrown (because of only thejson_last_error()is checked).According to PHP Docs there is a flag (JSON_PARTIAL_OUTPUT_ON_ERROR) for generating NULL values on
json_encode()error - such as resource encoding.So the expected behavior is no
InvalidArgumentExceptionis thrown if the value ofjson_last_error()is JSON_ERROR_UNSUPPORTED_TYPE and the JSON_PARTIAL_OUTPUT_ON_ERROR flag is set (because the generated JSON is valid).