[5.4] Implement until method on the EventFake
#19062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When dispatching events using the `until` method instead of the `dispatch` or `fire` methods, the given events were not being collected in the `events` array of the `EventFake` class. This was resulting false negatives, e.g. `assertDispatched` is failing because the `until` method is not implemented like the `fire` and `dispatch` methods. * Fixes laravel#18923
tillkruss
changed the title
until method on the EventFakeuntil method on the EventFake
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When dispatching events using the
untilmethod instead of thedispatchorfiremethods, the given events were not being collected in theeventsarray of theEventFakeclass.This was resulting false negatives, e.g.
assertDispatchedis failing because theuntilmethod is not implemented like thefireanddispatchmethods.This is useful for testing model halting events like
saving,creating,updating,deleting.