[5.4] fix: stop worker if a database disconnection occured - #19080
Merged
Conversation
fix: styleCI
fix spaces
refacto: add a $shouldStop property to force stopIfNecessary()
fix: remove useless use
Contributor
|
Title please. |
Member
|
I don't think we need a shouldStop and a shouldQuit. |
Broutard
changed the title
Broutard
changed the title
Broutard
changed the title
Contributor
Author
|
@taylorotwell the previous valid commit #96b465e only stop() the worker. |
Contributor
Author
|
Maybe a simple reconnect should do the trick... but if I reconnect on a job, other jobs still down |
tillkruss
changed the title
Member
|
Why not just use the existing shouldQuit variable? Why did you need to make a new one? |
Contributor
Author
|
The shouldQuit variable do a kill() and do not fire any event. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix issue #19072