[5.4] Adds ability to eager load counts via property - #19154
Merged
Conversation
This PR adds the ability to eager load counts via the protected property `$withCount` in the same way you can eager load relations with `$with`.
Like:
```
class FooBar extends \Illuminate\Database\Eloquent\Model
{
protected $with = ['foo', 'bar'];
protected $withCount = ['baz', 'qux'];
...
}
```
Contributor
|
Tests are failing. |
Contributor
Author
|
To pass the checks I have also added an early return in the |
Contributor
|
@regularlabs Thanks for this! 👍 I was not able to use nested relationships the same it works with The error that I get with the current implementation for the above example is: |
Contributor
|
@sausin It just uses withCount method which doesn't support nested relations. |
Contributor
|
@decadence Thanks for clearing it up! Should've checked the changes properly |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to eager load counts via the protected property
$withCountin the same way you can eager load relations with$with.Like: